Re: [PATCH v3 1/2] ACPI: video: get rid of magic numbers and use enum instead

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 19, 2017 at 10:15 PM, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> On Wed, Apr 19, 2017 at 9:44 PM, Dmitry Frank <mail@xxxxxxxxxxxxxxx> wrote:
>> Hi Rafael,
>>
>> On 04/19, Rafael J. Wysocki wrote:
>>> On Wed, Apr 19, 2017 at 12:36 PM, Dmitry Frank <mail@xxxxxxxxxxxxxxx> wrote:
>>> > The first two items in the _BCL method response are special:
>>> >
>>> >   - Level when machine has full power
>>> >   - Level when machine is on batteries
>>> >   - .... actual supported levels go there ....
>>> >
>>> > So this commits adds an enum and uses its descriptive elements
>>> > throughout the code, instead of magic numbers.
>>> >
>>> > Signed-off-by: Dmitry Frank <mail@xxxxxxxxxxxxxxx>
>>>
>>> Are there any differences between this and the previous version of the
>>> patch you posted?
>>>
>>
>> No; this patch is identical in both v2 and v3 patchsets.
>>
>> Differences between v3 and v2 are as follows: In v3 I removed the middle
>> patch (which was renaming the global flag device_id_scheme), and also
>> amended the last patch: added the comment for that flag. Everything else
>> is identical.
>
> OK, thanks!

The v2 has been applied.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux