On 19/04/17 23:57, Prakash, Prashanth wrote: > Hi Sudeep, > > On 4/19/2017 9:37 AM, Sudeep Holla wrote: >> On 30/03/17 01:13, Prashanth Prakash wrote: >>> Add support to expose idle statistics maintained by platform to >>> userspace via sysfs in addition to other data of interest from >>> each LPI(Low Power Idle) state. >>> >> While I understand this information is useful for some optimization >> and also for idle characterization with different workloads, I prefer >> to keep this in debugfs for: >> >> 1. We already have CPUIdle stats, this information may be more accurate >> which is good for above reasons but user-space applications shouldn't >> depend on it and end-up misusing it. >> 2. Also as more features get pushed into hardware, even these stats may >> not remain so much accurate as it is today and hence it would be >> better if user-space applications never use/depend on them. >> >> Let me know if there are conflicting reasons ? > The information about idle state of shared resources(Cache, interconnect ...) > which cannot be deduced from the cpuidle stats is quite useful. We can use this > to analyze newer workloads and to explain their power consumption, especially as > the amount of time some of these shared resources spends in different LPI states > can be influenced by changes to workload, kernel or firmware. And for auto > promote-able states this is the only way to capture idle stats. > I agree that the stats are useful, no argument there. The question is more in terms of whether it can be debugfs which is just useful in analysis and characterization or sysfs which becomes user ABI. > Regarding 2, since these stats are clearly defined by ACPI spec and maintained by > platform, I think it is reasonable to expect them to be accurate. If it is not accurate, > it is likely that platform is breaking the spec. > I was considering firmware vs hardware here. If f/w tracks and updates these statistics, it may not be so accurate in the future if more controls that are today done in f/w will be done automatically done in h/w. If h/w updates these statistics, then yes they will be accurate. I am still trying to convince myself if we need this as sysfs user ABI, so just thinking aloud. > Given above, I don't see much room for user-space applications to misuse this. You never know :) > Given these are defined as optional in spec, user-space application should use > only if/when available and use it as complementary to cpuidle stats. > Fair enough. [...] >> >>> | |-> flags >>> | |-> arch_flags >>> | >>> <<more states>> >>> >>> ACPI00XX can be ACPI0007(processor) or ACPI0010(processor container) >>> >>> stateX contains information related to a specific LPI state defined >>> in the LPI ACPI tables. >>> >>> summary_stats shows the stats(usage and time) from all the LPI states >>> under a device. The summary_stats are provided to reduce the number' >>> of files to be accessed by the userspace to capture a snapshot of the' >>> idle statistics. >> Really ? What's the need to reduce the no. of file accesses ? > When we have a large number of cores, with multiple idle state + few auto-promotable > states. The amount of files we need to access to get a snapshot before/after a running > a workload is quite high. > OK. Since I don't have much knowledge on that, I can't really comment, but I wonder why is that not done for many stats that are per-cpu today. > It gets worse if we want to keep the file handles open to sample it little more frequently, > to get breakdown of idle state distribution during different phases of a workload. On the contrary agreeing with you on issue with large no. of file handles, why not we have single stat file that provides all the information you need and be done with it ? Why do we need all this hierarchy of sysfs if the summary_stats can provide all those information broken down. [...] >>> + >>> + >>> +/* >>> + * LPI sysfs support >>> + * Exports two APIs that can be called as part of init and exit to setup the LPI >>> + * sysfs entries either from processor or processor_container driver >>> + */ >>> + >> [...] >> >> Lot of this sysfs handling looks similar to what we already have for >> cpuidle. I don't have a quick solution to avoid duplication but Greg >> really hate dealing with kobjects/ksets. I need to think if there's any >> better way to do this. Sorry for just raising issue without solution. > Given the hierarchical nature of LPI and presence of auto promote-able states, it was > hard to fit it to cpuidle model. I will take a look at it again, though I am not confident > about finding a solution to avoid duplication. Not a problem. I will also have a look, we can even do that later if required. -- Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
