On Wed, Mar 29, 2017 at 12:51 AM, Shanker Donthineni <shankerd@xxxxxxxxxxxxxx> wrote: > Hi Rafael, > > > On 03/28/2017 05:15 PM, Rafael J. Wysocki wrote: >> On Tuesday, March 28, 2017 05:14:13 PM Shanker Donthineni wrote: >>> Hi Rafael, >>> >>> >>> On 03/28/2017 04:43 PM, Rafael J. Wysocki wrote: >>>> On Tuesday, March 21, 2017 09:54:30 AM Shanker Donthineni wrote: >>>>> The optional _PXM method evaluates to an integer that identifies the >>>>> proximity domain of a device object. This patch implements support for >>>>> ACPI _PXM method and updates the platform device numa node id using >>>>> acpi_get_node(), which provides the PXM to NUMA mapping information. >>>>> >>>>> Signed-off-by: Shanker Donthineni <shankerd@xxxxxxxxxxxxxx> >>>> What exactly is the motivation here? >>> We have a couple of platform devices some of them are attached >>> to socket0 and others to a different socket. We would like to covert >>> memory allocations in Qualcomm platform device drivers to a NUMA >>> aware allocation to improve performance. >> All of the above information should be there in the patch changelog and >> presumably the patch should be a part of a larger series so the way this >> feature is going to be used is more clear. > > Sorry, I didn't quite get what's larger series? I'm happy to include above information in > commit/changelog text. We are trying to allocate memory using standard function > devm_kmalloc() but the function is always allocating memory from NUMA node 0. > The inline function dev_to_node(dev) always returns -1 on our system even though > we are setting PXM method in ACPI DSDT to non-zero value. OK So please add the above to the patch changelog too. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
