Hi Mika, Thank you for the review! On Tue, Mar 28, 2017 at 03:52:31PM +0300, Mika Westerberg wrote: > On Tue, Mar 28, 2017 at 03:22:19PM +0300, Sakari Ailus wrote: > > - ret = acpi_copy_property_array_string(items, (char **)val, nval); > > + ret = acpi_copy_property_array_string( > > + items, (char **)val, > > + min_t(u32, nval, obj->package.count)); > > I think this looks better if written like: > > ret = acpi_copy_property_array_string(items, (char **)val, > min_t(u32, nval, obj->package.count)); I prefer the former although I have no strong opinion either way. Using an indentation that is automatically intended by a text editor is also an advantage. I can change it if you insist. :-) > > Regardless of that, > > Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> Thanks! -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
