On Mon, 2017-03-20 at 18:20 +0100, Hans de Goede wrote: > Hi, > > On 19-03-17 16:25, Andy Shevchenko wrote: > > On Sun, 2017-03-19 at 00:35 +0100, Hans de Goede wrote: > > > On baytrail / cherrytrail systems with a LID switch the LID switch > > > is > > > often connect to a gpioint handled by an _IAE event handler. > > > Before this commit such systems would not wake up when opening the > > > lid, > > > requiring the powerbutton to be pressed after opening the lid to > > > wakeup. > > > > > > This commit calls enable_irq_wake() for _IAE GpioInts with a valid > > > event handler which have their Wake flag set. This fixes such > > > systems > > > not waking up when opening the lid. > > > > I perhaps give up on my nits against Capital Letters :-), though for > > consistency, please, use Baytrail, Cherry Trail. > > Will fix for v2. > > > > > > + if (event->irq_wake_enabled) > > > > You may use irqd_is_wakeup_set() instead. IRQ framework keeps this > > state > > already. > > That requires having irq_data which is only (normally) available to > irq_chip drivers, so that is not going to work here. Which you can get easily from IRQ line number. data = irq_get_irq_data(irq); if (irqd_is_wakeup_set(data)) Would this work? -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
