Hi,
On 20-03-17 14:10, Andy Shevchenko wrote:
On Mon, 2017-03-20 at 14:03 +0100, Hans de Goede wrote:
Hi,
Thank you for the reviews!
On 16-03-17 17:29, Andy Shevchenko wrote:
On Thu, 2017-03-16 at 17:15 +0100, Hans de Goede wrote:
@@ -31,6 +31,7 @@
#include <linux/delay.h>
#include <linux/slab.h>
#include <linux/suspend.h>
+#include <linux/mutex.h>
Keep in alphabetical order ?
I'm a fan of having headers in alphabetical order myself,
but if you look at the actual file, rather then the diff
context, you will see that this file uses random order.
Okay, but can you squeeze it in most ordered part?
+++ b/include/linux/power/acpi.h
E.g. for GPIO we keep such things directly in linux/acpi.h. Does it
make
sense to have separate one in this case?
I've taken include/acpi/video.h as example here. TBH I do not think
shoving everything acpi related into linux/acpi.h is a good idea.
So, let Rafael judge then. I have no strong opinion, just recall that
case.
Ack to both remarks.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
