On Sun, Mar 19, 2017 at 4:25 PM, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Sun, 2017-03-19 at 00:35 +0100, Hans de Goede wrote: >> On baytrail / cherrytrail systems with a LID switch the LID switch is >> often connect to a gpioint handled by an _IAE event handler. >> Before this commit such systems would not wake up when opening the >> lid, >> requiring the powerbutton to be pressed after opening the lid to >> wakeup. >> >> This commit calls enable_irq_wake() for _IAE GpioInts with a valid >> event handler which have their Wake flag set. This fixes such systems >> not waking up when opening the lid. > > I perhaps give up on my nits against Capital Letters :-), though for > consistency, please, use Baytrail, Cherry Trail. > >> + if (event->irq_wake_enabled) > > You may use irqd_is_wakeup_set() instead. IRQ framework keeps this state > already. > >> + disable_irq_wake(event->irq); Good point! Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
