Hi, > From: linux-acpi-owner@xxxxxxxxxxxxxxx [mailto:linux-acpi- > owner@xxxxxxxxxxxxxxx] On Behalf Of Paul Gortmaker > Subject: [PATCH 3/3] drivers/acpi: make pmic/intel_pmic_crc.c explicitly non- > modular > > The Kconfig currently controlling compilation of this code is: > > drivers/acpi/Kconfig:config CRC_PMIC_OPREGION > drivers/acpi/Kconfig: bool "ACPI operation region support for CrystalCove > PMIC" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple modular references, so that when reading > the driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. [Lv Zheng] Especially, this can pass module test if it is built along with a workaround to fix the ACPICA defects. The workaround is not upstreamed because it is just a workaround, real fix should be done inside of ACPICA. Thanks and best regards -Lv > > Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx> > Cc: Len Brown <lenb@xxxxxxxxxx> > Cc: Aaron Lu <aaron.lu@xxxxxxxxx> > Cc: linux-acpi@xxxxxxxxxxxxxxx > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> > --- > drivers/acpi/pmic/intel_pmic_crc.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/acpi/pmic/intel_pmic_crc.c > b/drivers/acpi/pmic/intel_pmic_crc.c > index 42df46a86c25..fcd1852dcdee 100644 > --- a/drivers/acpi/pmic/intel_pmic_crc.c > +++ b/drivers/acpi/pmic/intel_pmic_crc.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > */ > > -#include <linux/module.h> > +#include <linux/init.h> > #include <linux/acpi.h> > #include <linux/mfd/intel_soc_pmic.h> > #include <linux/regmap.h> > @@ -205,7 +205,4 @@ static int __init > intel_crc_pmic_opregion_driver_init(void) > { > return platform_driver_register(&intel_crc_pmic_opregion_driver); > } > -module_init(intel_crc_pmic_opregion_driver_init); > - > -MODULE_DESCRIPTION("CrystalCove ACPI operation region driver"); > -MODULE_LICENSE("GPL"); > +device_initcall(intel_crc_pmic_opregion_driver_init); > -- > 2.6.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
