An audit of i386/x86_64 allmodconfig builds found these instances of non-modular ACPI code needlessly using the modular equivalents of their built-in counterparts. In fixing that, we get rid of some dead code, make the mandate of the remaining code more clear, and leave behind better examples for future ACPI code to copy/emulate. Two of them are trivial, in that there is no binary output change. The other has dead code removal so the binary output will be slightly smaller. We've done a direct mapping of module_init to device_initcall in each instance, so there is no initcall reordering risks here. Overall, in all cases, the runtime should be completely unchanged. Where others have deployed module_param() already, we have to leave it, because there is no equivalent builtin_param (not yet) and we have to remain compatible with existing bootarg users. Paul. --- Cc: Aaron Lu <aaron.lu@xxxxxxxxx> Cc: Huang Ying <ying.huang@xxxxxxxxx> Cc: Josh Triplett <josh@xxxxxxxxxxxxxxxx> Cc: Len Brown <lenb@xxxxxxxxxx> Cc: Matthew Garrett <mjg59@xxxxxxxxxxxxx> Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx> Cc: linux-acpi@xxxxxxxxxxxxxxx Paul Gortmaker (3): drivers/acpi: make bgrt driver explicitly non-modular drivers/acpi: make apei/ghes.c more explicitly non-modular drivers/acpi: make pmic/intel_pmic_crc.c explicitly non-modular drivers/acpi/apei/ghes.c | 23 +++++++---------------- drivers/acpi/bgrt.c | 10 +++------- drivers/acpi/pmic/intel_pmic_crc.c | 7 ++----- 3 files changed, 12 insertions(+), 28 deletions(-) -- 2.6.1 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html