On Tue, Nov 10, 2015 at 06:05:15PM +0300, Dmitry Krivenok wrote: > > > list_for_each_entry(nvdimm_bus, &nvdimm_bus_list, list) { > > - if (nvdimm_bus->id == id) { > > + if (nvdimm_bus->id != id) > > I noticed another minor issue. You have switched from "==" to "!=" > here, but you didn't add "break" after ioctl is handled for the found > bus. > I added the continue. the code is going through a list and wants to only do action when it matches on id. but, we still want to go through entire list. -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett-Packard Enterprise ----------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html