Hi ,Rafael, > -----Original Message----- > From: Rafael J. Wysocki [mailto:rjw@xxxxxxxxxxxxx] > Sent: Tuesday, October 13, 2015 4:20 AM > To: Chen, Yu C > Cc: Zheng, Lv; linux-pm@xxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Zhang, Rui; Wysocki, Rafael J; Brown, Len > Subject: Re: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before > suspend-to-idle > > On Friday, October 09, 2015 09:50:21 AM Chen, Yu C wrote: > > Hi, LV > > > > > -----Original Message----- > > > From: Zheng, Lv > > > Sent: Friday, October 09, 2015 4:33 PM > > > To: Chen, Yu C; rjw@xxxxxxxxxxxxx; lenb@xxxxxxxxxx > > > Cc: linux-pm@xxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; linux- > > > kernel@xxxxxxxxxxxxxxx; Zhang, Rui > > > Subject: RE: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting > > > before suspend-to-idle > > > > > > Hi, Yu > > > > > > > From: Chen, Yu C > > > > Sent: Friday, October 09, 2015 4:20 PM > > > > > > > > > > > > acpi_status acpi_os_remove_interrupt_handler(u32 irq, > > > > acpi_osd_handler handler) > > > > > > Why don't you rename irq here to gsi to improve the readability? > > > The false naming and the wrong example written for this function are > > > probably the root causes of all other bad code. > > > So if we want to stop people making future mistakes, we need to > > > cleanup ourselves. > > > > > OK, will rewrite in next version. > > It would be good to change the subject of the patch too I think, because it is > not about wakeup IRQs only any more. > OK, will send another series of patches. Best Regards, Yu ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
