Hi, LV > -----Original Message----- > From: Zheng, Lv > Sent: Friday, October 09, 2015 4:33 PM > To: Chen, Yu C; rjw@xxxxxxxxxxxxx; lenb@xxxxxxxxxx > Cc: linux-pm@xxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Zhang, Rui > Subject: RE: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before > suspend-to-idle > > Hi, Yu > > > From: Chen, Yu C > > Sent: Friday, October 09, 2015 4:20 PM > > > > > > acpi_status acpi_os_remove_interrupt_handler(u32 irq, > > acpi_osd_handler handler) > > Why don't you rename irq here to gsi to improve the readability? > The false naming and the wrong example written for this function are > probably the root causes of all other bad code. > So if we want to stop people making future mistakes, we need to cleanup > ourselves. > OK, will rewrite in next version. > Thanks and best regards > -Lv > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html