On 8 July 2015 at 16:46, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> Hi Ashwin,
Hi,
> On Wed, Jul 8, 2015 at 10:28 PM, Ashwin Chaugule
> <ashwin.chaugule@xxxxxxxxxx> wrote:
>> On 8 July 2015 at 16:05, Ashwin Chaugule <ashwin.chaugule@xxxxxxxxxx> wrote:
>>> On 8 July 2015 at 15:55, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
>>>> Hi Ashwin,
>>>>
>>>> On Wed, Jul 8, 2015 at 9:16 PM, Ashwin Chaugule
>>>> <ashwin.chaugule@xxxxxxxxxx> wrote:
>>>>> Hi Rafael,
>>>>>
>
> [cut]
>
>>>>
>>>> Also I'm still unsure what the connection between _CST and CPPC is.
>>>>
>>>
>>> There isnt. But I'm missing where I've implied the dependency?
>>
>> Perhaps the confusion is coming from the introduction of ACPI_CST in
>> this file. I could leave it as it is and just separate out the
>> ACPI_PSS bits. But I figured, while I'm at it, I'd introduce ACPI_CST,
>> since we know the LPI stuff is coming up soon as a CST alternative
>> anyway. So if you prefer, I can drop the CST bits and maybe Sudeep can
>> address that as part of his LPI patchset?
>
> Yes, please. That would be much less confusing.
Deja Vu. :)
When I let processor_driver and processor_idle compile on ARM64, I get
a bunch of errors because processor_idle.c contains a lot of X86
specific defines. That is why I'd created the ACPI_CST option which
we'd enable only on X86.
I'm not entirely sure what these enums and functions should default
to, or what they should be on ARM specifically. Given that on ARM64
we're likely to use LPI as against CST, it seems the original approach
is better. Thoughts?
------8<------
rivers/acpi/processor_idle.c: In function ‘disabled_by_idle_boot_param’:
drivers/acpi/processor_idle.c:73:9: error: ‘boot_option_idle_override’
undeclared (first use in this function)
return boot_option_idle_override == IDLE_POLL ||
^
drivers/acpi/processor_idle.c:73:9: note: each undeclared identifier
is reported only once for each function it appears in
drivers/acpi/processor_idle.c:73:38: error: ‘IDLE_POLL’ undeclared
(first use in this function)
return boot_option_idle_override == IDLE_POLL ||
^
drivers/acpi/processor_idle.c:74:32: error: ‘IDLE_HALT’ undeclared
(first use in this function)
boot_option_idle_override == IDLE_HALT;
^
drivers/acpi/processor_idle.c: In function ‘acpi_safe_halt’:
drivers/acpi/processor_idle.c:121:3: error: implicit declaration of
function ‘arch_safe_halt’ [-Werror=implicit-function-declaration]
safe_halt();
^
drivers/acpi/processor_idle.c: In function ‘acpi_processor_get_power_info_cst’:
drivers/acpi/processor_idle.c:435:9: error:
‘boot_option_idle_override’ undeclared (first use in this function)
(boot_option_idle_override == IDLE_NOMWAIT)) {
^
drivers/acpi/processor_idle.c:435:38: error: ‘IDLE_NOMWAIT’ undeclared
(first use in this function)
(boot_option_idle_override == IDLE_NOMWAIT)) {
^
drivers/acpi/processor_idle.c: In function ‘acpi_idle_enter_bm’:
drivers/acpi/processor_idle.c:749:2: error: implicit declaration of
function ‘acpi_unlazy_tlb’ [-Werror=implicit-function-declaration]
acpi_unlazy_tlb(smp_processor_id());
^
drivers/acpi/processor_idle.c: In function ‘acpi_processor_power_init’:
drivers/acpi/processor_idle.c:1072:3: error: implicit declaration of
function ‘acpi_processor_cstate_check’
[-Werror=implicit-function-declaration]
max_cstate = acpi_processor_cstate_check(max_cstate);
^
drivers/acpi/processor_idle.c: In function ‘disabled_by_idle_boot_param’:
drivers/acpi/processor_idle.c:75:1: warning: control reaches end of
non-void function [-Wreturn-type]
}
^
------8<------
Regards,
Ashwin.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
