On Tue, Jun 09, 2015 at 04:12:52PM +0000, Moore, Robert wrote: > Well, you don't have to use it. ACPICA has done this in several other > places. Anyway, I'm hesitant to just remove it at this point. OK, understood. I'll send you an updated patch without the removal. /Jarkko > > -----Original Message----- > > From: Jarkko Sakkinen [mailto:jarkko.sakkinen@xxxxxxxxxxxxxxx] > > Sent: Tuesday, June 09, 2015 8:43 AM > > To: Moore, Robert > > Cc: Zheng, Lv; Wysocki, Rafael J; Len Brown; open list:ACPI COMPONENT > > AR...; open list:ACPI COMPONENT AR...; open list > > Subject: Re: [PATCH] acpi: update struct acpi_table_tpm2 > > > > On Tue, Jun 09, 2015 at 06:19:19PM +0300, Jarkko Sakkinen wrote: > > > On Tue, Jun 09, 2015 at 02:21:12PM +0000, Moore, Robert wrote: > > > > ACPICA usually defines any "related" data structures, just for user > > > > convenience. > > > > > > If you want to keep it, it's fine for me but we still probably use the > > > internal structure for it in tpm_crb driver (as tpm_tis uses internal > > > structure for CRB). > > > > Let me open this a little bit. Everytime we want to do some small change > > to control area (lets say TCG adds some flag) we would have to cycle them > > through you. > > > > And the changes are not coupled with ACPI in any possible way. This is > > only adds more maintenance burden to you and also to us. This structure is > > the main control structure for the CRB driver and will be refined many > > times in the future. There is no any kind of use to its fields outside of > > the CRB driver. > > > > /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
