Dan Williams <dan.j.williams@xxxxxxxxx> writes: Looks like the Kconfig stuff has been worked out between you and Rafael, so I won't comment on that. > diff --git a/drivers/block/nd/acpi.c b/drivers/block/nd/acpi.c > new file mode 100644 > index 000000000000..9f0b24390d1b > --- /dev/null > +++ b/drivers/block/nd/acpi.c > @@ -0,0 +1,475 @@ > +/* > + * Copyright(c) 2013-2015 Intel Corporation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of version 2 of the GNU General Public License as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + */ > +#include <linux/list_sort.h> > +#include <linux/module.h> > +#include <linux/list.h> > +#include <linux/acpi.h> > +#include "acpi_nfit.h" > +#include "libnd.h" > + > +static bool warn_checksum; > +module_param(warn_checksum, bool, S_IRUGO|S_IWUSR); > +MODULE_PARM_DESC(warn_checksum, "Turn checksum errors into warnings"); Is this just a debugging option? > + > +enum { > + NFIT_ACPI_NOTIFY_TABLE = 0x80, > +}; This is unused by this patch. The rest looks ok to me. -Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html