Re: [PATCH] ACPI / LPSS: Remove non-existing clock control from Intel Lynxpoint I2C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, January 23, 2015 12:52:39 PM Mika Westerberg wrote:
> On Fri, Jan 23, 2015 at 09:42:39AM +0200, Jarkko Nikula wrote:
> > Intel Lynxpoint I2C does not have clock parameter register like SPI and UART
> > do have. Therefore remove LPSS_CLK_GATE flag from the Lynxpoint I2C device
> > description in order to not needlessly toggle clock enable bit in
> > non-existing register.
> > 
> > Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> > ---
> > For linux-next branch. This has been here since commit f58b082aed43
> > ("ACPI / scan: Add special handler for Intel Lynxpoint LPSS devices")
> > without known problems.
> > 
> > Mika: I assumed this holds true for INT3432 and INT3433 too?
> 
> Yes.
> 
> IIRC there used to be versions of Lynxpoint where the clock was actually
> gated even if the document said the register is reserved. That's why the
> I2C still tries to ungate the clock.
> 
> As long as you tested this properly,
> 
> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Queued up for 3.20 then, thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux