On Monday, December 15, 2014 08:47:52 AM Lv Zheng wrote:
> The ec_remove_handlers() is invoked without checking
> EC_FLAGS_HANDLERS_INSTALLED, this patch enhances this check to avoid issues
> that acpi_disable_gpe() is invoked unexpectedly to reduce the GPE runtime
> count. This may happen when the EC handler installation failed on some
> platforms.
>
> Reported-by: Venkat Raghavulu <venkat.raghavulu@xxxxxxxxx>
> Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>
Applied, thanks!
> ---
> drivers/acpi/ec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 5f9b74b..1b5853f 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -844,6 +844,8 @@ static int ec_install_handlers(struct acpi_ec *ec)
>
> static void ec_remove_handlers(struct acpi_ec *ec)
> {
> + if (!test_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags))
> + return;
> acpi_disable_gpe(NULL, ec->gpe);
> if (ACPI_FAILURE(acpi_remove_address_space_handler(ec->handle,
> ACPI_ADR_SPACE_EC, &acpi_ec_space_handler)))
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
