On Tuesday, December 16, 2014 11:21:15 AM Aaron Lu wrote: > On 12/15/2014 05:02 PM, Jani Nikula wrote: > > On Mon, 15 Dec 2014, Aaron Lu <aaron.lu@xxxxxxxxx> wrote: > >> If the firmware has declared more than 8 video output devices, and the > >> one that control the internal panel's backlight is listed after the > >> first 8 output devices, the _DOD will not include it due to the current > >> i915 operation region implementation. As a result, we will not create a > >> backlight device for it while we should. Solve this problem by special > >> case the firmware that has 8+ output devices in that if we see such a > >> firmware, we do not test if the device is in _DOD list. The creation of > >> the backlight device will also enable the firmware to emit events on > >> backlight hotkey press when the acpi_osi= cmdline option is specified on > >> those affected ASUS laptops. > >> > >> Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=70241 > >> Reported-and-tested-by: Oleksij Rempel <linux@xxxxxxxxxxxxxxxx> > >> Reported-and-tested-by: Dmitry Tunin <hanipouspilot@xxxxxxxxx> > >> Reported-and-tested-by: Jimbo <jaime.91@xxxxxxxxxx> > >> Cc: stable@xxxxxxxxxxxxxxx > >> Signed-off-by: Aaron Lu <aaron.lu@xxxxxxxxx> > > > > Obviously I'd like to have the proper information in the opregion > > DIDL/CADL fields, but it's not going to happen soon, nor is it going to > > fit under stable size limits. > > > > I like the simplicity here. FWIW, > > > > Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > Thanks :-) > > BTW, this patch is more of a fix for my previous commit 0b8db271f159 > ("ACPI / video: check _DOD list when creating backlight devices") that > made the acpi_video interface disappear on these affected laptops so I > would like to fix it quickly. And I agree that a proper implementation > of the DIDL/CADL list is needed so that people can get rid of the > acpi_osi= cmdline option they currently need to get hotkey events. Patch applied, thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
