On Tuesday, November 25, 2014 02:48:48 PM Sudeep Holla wrote: > phys_id in acpi_processor structure is unsigned 32-bit integer, > comparing it with signed value is incorrect. > > This patch removes that incorrect comparision in acpi_processor_hotadd_init > as the lone user of this function is already checking for correctness > of phys_id before calling it. > > Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx> This one depens on commits I've dropped due to conflicts with the tip tree. They'll need to be rebased on top of current linux-next and resent. I can take patches [2-3/3], though. > --- > drivers/acpi/acpi_processor.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c > index c4a8a5666298..eaf56f6ce1eb 100644 > --- a/drivers/acpi/acpi_processor.c > +++ b/drivers/acpi/acpi_processor.c > @@ -170,9 +170,6 @@ static int acpi_processor_hotadd_init(struct acpi_processor *pr) > acpi_status status; > int ret; > > - if (pr->phys_id == -1) > - return -ENODEV; > - > status = acpi_evaluate_integer(pr->handle, "_STA", NULL, &sta); > if (ACPI_FAILURE(status) || !(sta & ACPI_STA_DEVICE_PRESENT)) > return -ENODEV; > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
