On Thu, Oct 30, 2014 at 04:40:05PM +0100, Linus Walleij wrote: > > Yes, I'll just let dust to settle before sending out a patch that > > converts the existing users of platform_gpio_blink_set() callback to > > gpio descriptors. > > Dust settle = 2 weeks, 18 months, 5 years? I started to do the conversion already but then noticed that it is not that trivial after all. For example we have one user in arch/arm/mach-orion5x/dns323-setup.c: static struct gpio_led_platform_data dns323ab_led_data = { .num_leds = ARRAY_SIZE(dns323ab_leds), .leds = dns323ab_leds, .gpio_blink_set = orion_gpio_led_blink_set, }; orion_gpio_led_blink_set() is part of orion specific custom GPIO "driver" defined in arch/arm/plat-orion/gpio.c and as far as I can tell cannot use GPIO descriptors as it directly programs these numbers to the hardware. We can convert the descriptor to a number in the beginning of orion_gpio_led_blink_set() if that helps. Other two users: rx1950_led_blink_set() and h1940_led_blink_set() seem to have similar needs for the numeric value. > Sorry for nagging but I've been *SO* burnt by people in the past > saying they will "fix things later real soon" and then never get around > to it. Understood. > But I guess I'm gonna trust you anyway. Thanks :) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html