On Thu, Sep 25, 2014 at 10:57:26AM +0800, Aaron Lu wrote: > The virtual GPIO introduced in ACPI table of Baytrail-T based system is > used to solve a problem under Windows. We do not have such problems > under Linux so we do not actually need them. But we have to tell GPIO > library that the Crystal Cove GPIO chip has this many GPIO pins or the > common GPIO handler will refuse any access to those high number GPIO > pins, which will resulted in a failure evaluation of every ACPI control > method that is used to turn on/off power resource and/or report sensor > temperatures. > > Signed-off-by: Aaron Lu <aaron.lu@xxxxxxxxx> Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> A minor nit, see below: > --- > v2: remove the hunk to increase NR_GPIO to 512. > > drivers/gpio/gpio-crystalcove.c | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c > index e3712f0e51ab..186b76ef71a1 100644 > --- a/drivers/gpio/gpio-crystalcove.c > +++ b/drivers/gpio/gpio-crystalcove.c > @@ -24,6 +24,7 @@ > #include <linux/mfd/intel_soc_pmic.h> > > #define CRYSTALCOVE_GPIO_NUM 16 > +#define CRYSTALCOVE_VGPIO_NUM 0x5e I would rather see this spelled in decimal base. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
