RE: [PATCH v7 1/2] Mailbox: Add support for Platform Communication Channel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Ashwin

> From: Ashwin Chaugule [mailto:ashwin.chaugule@xxxxxxxxxx]
> Sent: Sunday, September 14, 2014 6:05 AM
> 
> Hi Mark,
> 
> On 13 September 2014 11:57, Mark Brown <broonie@xxxxxxxxxx> wrote:
> > On Fri, Sep 12, 2014 at 09:08:08AM -0400, Ashwin Chaugule wrote:
> >> On 10 September 2014 13:20, Ashwin Chaugule <ashwin.chaugule@xxxxxxxxxx> wrote:
> >
> >> How does this version look? If there are no more changes, please let
> >> me know which tree this can be picked by and I can send a pull request
> >> if that is preferred for this single patch.
> >
> > Please allow a reasonable time for review - you're nagging after two
> > days, this is unreasonable for something that isn't super urgent.  Two
> > weeks would be more reasonable.  As things stand you're adding to the
> > mail volume and some people will actively delay looking at things in
> > order to avoid encouraging such behaviour.
> 
> I apologize if it seems that way. I very much appreciate the help I've
> received so far. I'd sent V6 9 days ago and only Lv had feedback
> around cosmetic changes. Given the simplicity of this patch and all
> the previous suggestions, it seemed like we're nearly done with the
> reviews. I understand your point though and look forward to seeing
> this patch progress.

It looks this line is still wrong:
+	return ACPI_SUCCESS(status) ? -EINVAL : 0;
You may need to run a test to validate the revised patch.

Thanks and best regards
-Lv
��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux