On 08/20/2013 03:29 AM, Toshi Kani wrote:
On Fri, 2013-08-16 at 15:06 +0800, Tang Chen wrote:
The comment about return value of acpi_table_parse() is incorrect.
This patch fix it.
Furthermore, if the table is not found, return 1 means nothing, and
make it difficult to write the comment. So return -ENOENT when the
table is not found, and correct the comment.
I am OK with the change, but the above description is not very clear.
You should state that all callers only check if the function succeeded
or not. So, you are simplifying the semantics by returning -errno for
all failure cases.
Since you are making this change, I'd suggest you also update the stub
function in linux/acpi.h to return -ENODEV as well.
OK, followed. And will merge patch 3 and 4 and resend them later.
Thanks for reviewing.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
