On 08/12/2013 10:21 PM, Tejun Heo wrote:
On Thu, Aug 08, 2013 at 07:09:53AM -0700, Joe Perches wrote:
If you really think that the #define is better, use
something like HW_ERR does and embed that #define
in the pr_err.
#define ACPI_OVERRIDE "ACPI OVERRIDE: "
pr_err(ACPI_OVERRIDE "Table smaller than ACPI header [%s%s]\n",
cpio_path, file.name);
It's only used a few times by a single file so
I think it's unnecessary.
I agree with Joe here. Just doing normal pr_err() should be enough.
You can use pr_fmt() to add headers but given that we aren't talking
about huge number of printks, that probably is an overkill too.
OK, followed.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
