On Sun, Aug 4, 2013 at 6:20 AM, Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote: > On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: >> On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: >>> On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: >>> > On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: >>> >>> >> Yes, the patch is correct, but I still prefer my own version :-) >>> >> https://github.com/aaronlu/linux/commit/0a3d2c5b59caf80ae5bb1ca1fda0f7bf448b38c9 >>> >> >>> >> In case you want to take mine and mine needs refresh, please let me know >>> >> and I can do the re-base, thanks. >>> > >>> > Well, I prefer simpler, unless there's a good reason to use more complicated. >>> >>> Note that these are not exclusionary; his patch can be applied on top >>> of mine. I don't think his patch is needed though. >> >> OK >> >> Do we still need to revert commit efaa14c if this patch is applied? > > I guess not. At least in this machine changing the backlight works > correctly, whereas in v3.11-rc3 it was all weird, and v3.7-v3.10 > didn't work at all. I cannot see how it would affect negatively other > machines. That commit makes hotkey emit notifications, and it's not the problem of "booting into a black screen", that problem is due to broken _BQC. BTW, the efaa14c will also make screen off at level 0 according to Felipe, who consider this is a bug. But since it is required to let firmware emit notifications on hotkey press, I think user will want it. -Aaron > > That being said, the blacklisting is still needed, because 1. the > level is not preserved between boots, and 2. level 0 turns off the > screen, which I personally consider a regression. > > At least it boots to level 100 instead of 0. > > -- > Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
