RE: [PATCH 03/16] ACPICA: Standardize all switch() blocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



There were some really bad examples, where 2 or even 3 blank lines were inserted. These were the most severe cases. So we standardized on one blank line, unless there is a multi-line comment.


> -----Original Message-----
> From: lenb417@xxxxxxxxx [mailto:lenb417@xxxxxxxxx] On Behalf Of Len Brown
> Sent: Wednesday, June 12, 2013 8:59 AM
> To: Zheng, Lv
> Cc: Wysocki, Rafael J; Moore, Robert; Brown, Len; linux acpi; Guan, Chao
> Subject: Re: [PATCH 03/16] ACPICA: Standardize all switch() blocks
> 
> > After many years, different formatting for switch() has crept in.
> > This change makes every switch block identical. Chao Guan.
> > ACPICA bugzilla 997.
> 
> So what is the new format?
> Looks like a blank line after every "case", except no blank line if
> comment?
> 
> That would be a good thing to say in the commit message...
> 
> Also, for patches such as this, please note in the commit message that it
> is white-space only (indeed, in this case looks like blank lines only) and
> no functionality changes.
> 
> That would help optimize precious reviewer time, and also make it clear to
> those doing a bisect who read only the commit message and not the patch.
> 
> thanks,
> Len Brown
> Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux