On Fri, May 17, 2013 at 11:07:16AM +0200, Borislav Petkov wrote: > Date: Fri, 17 May 2013 11:07:16 +0200 > From: Borislav Petkov <bp@xxxxxxxxx> > To: tony.luck@xxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/2] ACPI/APEI: Add parameter check before error > injection > User-Agent: Mutt/1.5.21 (2010-09-15) > > On Fri, May 17, 2013 at 01:09:32AM -0400, Chen Gong wrote: > > IMHO, I don't think your attached patch has obvious improvment. I > > paste my updated patch here and please continue to review. I will send > > updated patch based on your further review. > > I already did my review. Having a bool checkparam and querying it > straight afterwards is clumsy code. Also you're adding a redundant > definiton of PAGE_MASK even though it already exists in the kernel. > Maybe you should've grepped the sources first... > > Not to mention that this check seems wrong: > > ((param2 & PAGE_MASK) != PAGE_MASK) Oops, it's my fault. I missed this stupid error. One reason is I like to use Ctrl + P in VIM to match words, meanwhile, I often set ignorecase in VIM so that I hitted this fault. I accept your suggestion and resend it soon.
Attachment:
signature.asc
Description: Digital signature
