On Fri, May 17, 2013 at 01:09:32AM -0400, Chen Gong wrote:
> IMHO, I don't think your attached patch has obvious improvment. I
> paste my updated patch here and please continue to review. I will send
> updated patch based on your further review.
I already did my review. Having a bool checkparam and querying it
straight afterwards is clumsy code. Also you're adding a redundant
definiton of PAGE_MASK even though it already exists in the kernel.
Maybe you should've grepped the sources first...
Not to mention that this check seems wrong:
((param2 & PAGE_MASK) != PAGE_MASK)
But hey, I have better things to do instead of wasting time with this.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
