Sarah Sharp wrote: > On Thu, Apr 04, 2013 at 07:30:19PM +0800, Huang Ying wrote: >> Hi, Martin, >> >> On Wed, 2013-04-03 at 14:16 +0200, Martin Mokrejs wrote: >>>>> 2) xHCI dead due to to its suspend - 3.8 series and above >>>> >>>> Not fixed by port_dbg.patch applied over 3.8.5. Interestingly, a NEC-based >>>> XHCI card *in an express card slot* does not suffer this suspend issue. >>>> Although it is being put into suspend if a device is unplugged. >>> >>> 20130402/3.8.5-ying_port-dbg__with_laptop-mode-tools_xHCI_test_TI-based >>> 20130402/3.8.5-ying_port-dbg__with_laptop-mode-tools_xHCI_test_NEC-based >>> >>> Same thing but yet without the port_dbg.patch: >>> 20130402/3.9-rc5__with_2368081__with-latop-mode-tools_xhci_testing/ >> >> It appears that TI xHCI dead port issue will present even if the PCIe >> port will never go suspended. So I think this bug is not related to >> PCIe port runtime PM but related to USB xHCI. >> >> Do you agree Sarah? > > No. The symptoms he described (in another email) were that the port > only becomes "dead" after a USB 2.0 device is removed, and the host was > suspended. The issue was that the TI host is simply not reporting the > USB device connect, even if it is manually resumed. The port status > registers do not show a device connect at all. > > Martin, can you confirm this by trying this, and sending me dmesg of the > test with CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING turned on: > > 1. Remove the laptop mode tools > 2. Reboot with no USB devices attached to the TI host > 3. Make sure the xHCI PCI device's power/control file is set to 'on' > You will find that file in /sys/bus/pci/devices/. Use lspci to > figure out which directory is the xHCI PCI device. > 4. Plug in a USB 2.0 device and make sure it works (e.g. wiggle a > mouse) > 5. Unplug the device, replug it, and check to see if it works. Works. Actually, I plugged in the mouse in and out several times to show that the *unplug* does not kill the socket. > If you have problems, stop here. Otherwise try: > > 6. Unplug all USB devices > 7. echo 'auto' to the xHCI PCI device's power/control file in The 0b:00.0 is already suspended after the echo 'auto', but I tried to continue with step 8. Some default kicks in? > 8. echo 'auto' to both xHCI roothubs in /sys/bus/usb/devices/ > (i.e. all usbN directories) No need, they are already suspended: # cat /sys/devices/pci0000\:00/0000:00:1c.4/0000:0b:00.0/usb3/power/control auto # cat /sys/devices/pci0000\:00/0000:00:1c.4/0000:0b:00.0/usb3/power/runtime_status suspended # cat /sys/devices/pci0000\:00/0000:00:1c.4/0000:0b:00.0/usb4/power/runtime_status suspended # > 9. Wait a few seconds or so until the xHCI PCI host suspends, meaning the > power/runtime_status file reads as 'suspended' > 10. Plug in the same USB 2.0 device, and check if it works. It works. > 11. Unplug the device, and wait until the PCI host is suspended. Unplug causes death per dmesg. [ 932.419828] xhci_hcd 0000:0b:00.0: Cached old ring, 1 ring cached [ 932.420240] xhci_hcd 0000:0b:00.0: // Ding dong! [ 932.420342] xhci_hcd 0000:0b:00.0: get port status, actual port 1 status = 0x2a0 [ 932.420344] xhci_hcd 0000:0b:00.0: Get port status returned 0x100 [ 932.454637] xhci_hcd 0000:0b:00.0: get port status, actual port 1 status = 0x2a0 [ 932.454638] xhci_hcd 0000:0b:00.0: Get port status returned 0x100 [ 932.494828] xhci_hcd 0000:0b:00.0: get port status, actual port 1 status = 0x2a0 [ 932.494831] xhci_hcd 0000:0b:00.0: Get port status returned 0x100 [ 932.534856] xhci_hcd 0000:0b:00.0: get port status, actual port 1 status = 0x2a0 [ 932.534859] xhci_hcd 0000:0b:00.0: Get port status returned 0x100 [ 932.574871] xhci_hcd 0000:0b:00.0: get port status, actual port 1 status = 0x2a0 [ 932.574874] xhci_hcd 0000:0b:00.0: Get port status returned 0x100 [ 932.574888] hub 3-0:1.0: debounce: port 2: total 100ms stable 100ms status 0x100 [ 932.574905] hub 3-0:1.0: hub_suspend [ 932.574912] usb usb3: bus auto-suspend, wakeup 1 [ 932.574928] xhci_hcd 0000:0b:00.0: xhci_hub_status_data: stopping port polling. [ 932.574947] xhci_hcd 0000:0b:00.0: xhci_suspend: stopping port polling. [ 932.574974] xhci_hcd 0000:0b:00.0: // Setting command ring address to 0xd6007001 [ 932.575026] xhci_hcd 0000:0b:00.0: hcd_pci_runtime_suspend: 0 [ 932.575119] xhci_hcd 0000:0b:00.0: PME# enabled [ 932.594863] xhci_hcd 0000:0b:00.0: pfrs: target: 3, 0 > 12. Replug the device, and check to see if it works. Is dead. Full logs at: http://195.113.57.32/~mmokrejs/tmp/20130405.tar.bz2 (unpack, 'ls -latr', diff as you like). Also .config is in there. Martin -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
