On Wed, 5 Dec 2012 16:31:21 +0100 Borislav Petkov <bp@xxxxxxxxx> wrote: > On Wed, Dec 05, 2012 at 03:27:56PM +0000, Alan Cox wrote: > > On Wed, 5 Dec 2012 15:29:35 +0100 > > Borislav Petkov <bp@xxxxxxxxx> wrote: > > > > > On Wed, Dec 05, 2012 at 08:09:01AM +0100, Andreas Mohr wrote: > > > > Hi, > > > > > > > > drivers/pnp/pnpacpi/core.c: In function 'ispnpidacpi': > > > > drivers/pnp/pnpacpi/core.c:65:2: warning: logical 'or' of collectively > > > > exhaustive tests is always true [-Wlogical-op] > > > > drivers/pnp/pnpacpi/core.c:66:2: warning: logical 'or' of collectively > > > > exhaustive tests is always true [-Wlogical-op] > > > > drivers/pnp/pnpacpi/core.c:67:2: warning: logical 'or' of collectively > > > > exhaustive tests is always true [-Wlogical-op] > > > > > > > > > > > > That's already the second less enticing -Wlogical-op issue > > > > which was discovered by accident during less than two days > > > > No it's not. It's been reported in bugzilla. I sent patches ages ago. > > They were ignored. Coverity has had it tagged for years (and a ton more > > of them you've not noticed yet) > > > > http://article.gmane.org/gmane.linux.acpi.devel/56753/match=test_alpha > > > > This isn't discovered, this is in the "If you stick your fingers in your > > ears and hum you can't hear the screaming" category. > > Hillarious! > > Andrew, would you please pick up Alan's patch? It clearly fixes an > ancient bug in the pnpacpi code. > Bjorn had a review comment which appears to remain unaddressed: : The original is definitely broken. : : I think the corrected test allows PNP IDs containing '@', which : doesn't appear legal per sec 6.1.5 of the ACPI 5.0 spec. Should this : be : : + if (!('A' <= (c) && (c) <= 'Z')) \ : : instead? Also, the original patch is missing a signed-off-by. Here's what I have queued: From: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> Subject: pnpacpi: fix incorrect TEST_ALPHA() test TEST_ALPHA() is broken and always returns 0. [akpm@xxxxxxxxxxxxxxxxxxxx: return false for '@' as well, per Bjorn] Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> Cc: Borislav Petkov <bp@xxxxxxxxx> Cc: Andreas Mohr <andi@xxxxxxxx> Cc: Li Shaohua <shaohua.li@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/pnp/pnpacpi/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/pnp/pnpacpi/core.c~pnpacpi-fix-incorrect-test_alpha-test drivers/pnp/pnpacpi/core.c --- a/drivers/pnp/pnpacpi/core.c~pnpacpi-fix-incorrect-test_alpha-test +++ a/drivers/pnp/pnpacpi/core.c @@ -58,7 +58,7 @@ static inline int __init is_exclusive_de if (!(('0' <= (c) && (c) <= '9') || ('A' <= (c) && (c) <= 'F'))) \ return 0 #define TEST_ALPHA(c) \ - if (!('@' <= (c) || (c) <= 'Z')) \ + if (!('A' <= (c) && (c) <= 'Z')) \ return 0 static int __init ispnpidacpi(const char *id) { _ -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
