On Thursday, November 29, 2012 01:26:48 PM Zdenek Kabelac wrote: > Dne 29.11.2012 11:59, Rafael J. Wysocki napsal(a): > > On Thursday, November 29, 2012 11:13:10 AM Zdenek Kabelac wrote: > >> Dne 28.11.2012 20:07, Linus Torvalds napsal(a): > >>> whole "prefix_node" pointer is bogus. It seems to have the value 0x1000. > >> > >> Tested also this patch with this result: > >> > >> https://bugzilla.kernel.org/show_bug.cgi?id=51071#c8 > >> > >> So while it's made it pass suspend/resume, it's not really usable > >> as docking then. > > > > This just makes acpi_ns_lookup() always return acpi_gbl_root_node > > for things looked up by acpi_ns_get_node() as far as I can say. > > > > Hmm. > > > > If my theory correct, the patch below should catch the bug. Can you please > > test it? > > > > Ok now crashing right after 'undock' button press: > > https://bugzilla.kernel.org/show_bug.cgi?id=51071#c10 And that's because I made a mistake in the patch. We're currently testing the appended one and it's showing that the added WARN_ON_ONCE() actually triggers, so the theory appears to be correct. I think we can debug this further in the Bugzilla. Thanks, Rafael --- drivers/acpi/scan.c | 2 ++ drivers/pnp/pnpacpi/rsparser.c | 3 +++ 2 files changed, 5 insertions(+) Index: linux/drivers/acpi/scan.c =================================================================== --- linux.orig/drivers/acpi/scan.c +++ linux/drivers/acpi/scan.c @@ -707,6 +707,8 @@ static void acpi_device_unregister(struc acpi_device_remove_files(device); device_unregister(&device->dev); + + device->handle = ERR_PTR(-ENODEV); } /* -------------------------------------------------------------------------- Index: linux/drivers/pnp/pnpacpi/rsparser.c =================================================================== --- linux.orig/drivers/pnp/pnpacpi/rsparser.c +++ linux/drivers/pnp/pnpacpi/rsparser.c @@ -611,6 +611,9 @@ int pnpacpi_build_resource_template(stru int res_cnt = 0; acpi_status status; + if (WARN_ON_ONCE(IS_ERR(handle))) + return PTR_ERR(handle); + status = acpi_walk_resources(handle, METHOD_NAME__CRS, pnpacpi_count_resources, &res_cnt); if (ACPI_FAILURE(status)) { -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
