On Tuesday, November 27, 2012 05:33:55 AM Zheng, Lv wrote: > > > This patch will not affect the generated vmlinux binary. > > > > If this is the goal, then please VERIFY that the goal was met by building both > > ways and comparing the kernel. > > It's not the goal of this patch, it should be better stated as no function changes. > > > due to the hunk below, we know that this patch DOES change the kernel, and > > not in a correct way: > > > > > diff --git a/drivers/acpi/acpica/tbutils.c > > > b/drivers/acpi/acpica/tbutils.c index 285e24b..b4469a6 > > > 100644 > > > --- a/drivers/acpi/acpica/tbutils.c > > > +++ b/drivers/acpi/acpica/tbutils.c > > > @@ -384,10 +384,6 @@ void acpi_tb_check_dsdt_header(void) > > > acpi_tb_print_table_header(0, &acpi_gbl_original_dsdt_header); > > > acpi_tb_print_table_header(0, acpi_gbl_DSDT); > > > > > > - ACPI_ERROR((AE_INFO, > > > - "Please send DMI info to linux-acpi@xxxxxxxxxxxxxxx\n" > > > - "If system does not work as expected, please boot with > > acpi=copy_dsdt")); > > > - > > > /* Disable further error messages */ > > > > Please retain this difference between Linux and ACPICA -- it is there for a > > reason. > > Agreed. > I shouldn't make this vanished. > I will add this back to Linux during the next release if this is needed. No, the next release would be too late. Please do it now. Please address all of the Len's comments in all of the patches and resend the whole series. And _please_ be more careful, I asked you for that last time already. I'll drop it from linux-next for now and will wait for the new submissoion. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
