On Mon, 2012-11-19 at 08:06 -0800, Joe Perches wrote:
> On Mon, 2012-11-19 at 08:51 -0700, Toshi Kani wrote:
> > On Mon, 2012-11-19 at 00:56 -0800, Joe Perches wrote:
> > > is acpi_bus.h really the right file for these prototypes?
> > This interface is limited for ACPI, so it should be declared in a header
> > file under include/acpi. Among the files in this directory, acpi_bus.h
> > seems to be a good fit as it declares the interfaces provided by ACPI
> > core.
>
> I'd've put them in acpi.h or maybe created acpi_utils.h
Hi Joe,
We cannot use acpi.h since it is an ACPICA header. Creating
acpi_utils.h sounds good idea. However, in line 40 of acpi_bus.h, it
has the following comment and declares multiple utility interfaces.
====
/* acpi_utils.h */
acpi_status
acpi_extract_package(union acpi_object *package,
struct acpi_buffer *format, struct acpi_buffer *buffer);
:
====
This looks to me that there was acpi_utils.h before, but someone had
merged it into acpi_bus.h for some reason. This change was made before
the initial git repository was created, so I cannot check the change
log. So, as of today, acpi_bus.h seems to be the place to declare ACPI
utility interfaces for ACPI core.
Thanks,
-Toshi
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
