On Mon, 2012-11-19 at 00:56 -0800, Joe Perches wrote: > On Tue, 2012-11-06 at 08:02 -0700, Toshi Kani wrote: > > This patch introduces acpi_pr_<level>(), where <level> is a kernel > > message level such as err/warn/info, to support improved logging > > messages for ACPI, esp. for hotplug operations. > [] > > diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h > [] > > @@ -56,6 +56,37 @@ acpi_evaluate_hotplug_ost(acpi_handle handle, u32 source_event, > > > > acpi_status > > acpi_get_physical_device_location(acpi_handle handle, struct acpi_pld_info **pld); > > + > > +void acpi_printk(const char *level, acpi_handle handle, const char *fmt, ...); > > This should be declared with __printf(3, 4) Hi Joe, Yes, I will add __printf(3,4). Thanks for pointing this out. > is acpi_bus.h really the right file for these prototypes? This interface is limited for ACPI, so it should be declared in a header file under include/acpi. Among the files in this directory, acpi_bus.h seems to be a good fit as it declares the interfaces provided by ACPI core. Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
