On Monday, July 23, 2012, Zhang Rui wrote: > On 四, 2012-07-19 at 22:55 +0200, Rafael J. Wysocki wrote: > > On Thursday, July 19, 2012, Zhang Rui wrote: > > > set upper and lower limits when binding > > > a thermal cooling device to a thermal zone device. > > > > > > Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx> > > > --- > > > Documentation/thermal/sysfs-api.txt | 6 ++++- > > > drivers/acpi/thermal.c | 49 ++++++++++++++++++++++------------- > > > drivers/platform/x86/acerhdf.c | 2 +- > > > drivers/thermal/thermal_sys.c | 20 +++++++++----- > > > include/linux/thermal.h | 3 ++- > > > 5 files changed, 53 insertions(+), 27 deletions(-) > > > > > > diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt > > > index b7b3609..f169821 100644 > > > --- a/Documentation/thermal/sysfs-api.txt > > > +++ b/Documentation/thermal/sysfs-api.txt > > > @@ -84,7 +84,7 @@ temperature) and throttle appropriate devices. > > > > > > 1.3 interface for binding a thermal zone device with a thermal cooling device > > > 1.3.1 int thermal_zone_bind_cooling_device(struct thermal_zone_device *tz, > > > - int trip, struct thermal_cooling_device *cdev); > > > + int trip, struct thermal_cooling_device *cdev, long upper, long lower); > > > > > > This interface function bind a thermal cooling device to the certain trip > > > point of a thermal zone device. > > > @@ -93,6 +93,10 @@ temperature) and throttle appropriate devices. > > > cdev: thermal cooling device > > > trip: indicates which trip point the cooling devices is associated with > > > in this thermal zone. > > > + upper:the Maximum cooling state for this trip point. > > > + -1 means no upper limit, and the cooling device can be in max_state. > > > + lower:the Minimum cooling state can be used for this trip point. > > > + -1 means no lower limit, and the cooling device can be in cooling state 0. > > > > If we have to use -1 (or all ones for unsigned long), I'd suggest to define a > > constant called CS_NO_LIMIT or something like that and use it instead of the > > plain numbers. > > > agreed. > > > And perhaps change the name of the above to > > thermal_zone_bind_cooling_device_limits() and define > > thermal_zone_bind_cooling_device() as a static inline that will not take the > > extra two arguments and make it call thermal_zone_bind_cooling_device_limits() > > with the CS_NO_LIMIT values in there. > > > then you mean there are two APIs for binding? > users can invoke thermal_zone_bind_cooling_device if they do not care > the limits? Yes. > Hmm, I do not think we need to do this. And further more, as there are > and there will be more and more parameters for binding, say, maybe > weight/influence in the near future, The majority of existing users don't care, it appears (as follows from the rest of your patch). > I'm thinking of using a struct thermal_bind_params to pass the parameters > instead. Yes, you can do that if you know already that more parameters will be necessary. Still, a wrapper passing NULL in there may be useful for some users. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
