Re: power_meter driver location

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 26, 2011 at 06:25:43PM +0200, Jean Delvare wrote:
> Hi Len, hi all,
> 
> Currently the ACPI power meter driver lives in drivers/acpi, and
> depends on HWMON. I don't think it makes sense because, in the
> configuration menu, the user sees the ACPI options first, and HWMON
> comes later, so if HWMON is disabled, the user has no idea that the
> ACPI power meter driver exists. It happens that CONFIG_HWMON currently
> defaults to y so this scenario won't happen on new configurations, but
> it could still happen when people upgrade an old configuration. It
> could also happen that a user selects the ACPI power meter, then looks
> at the driver list under CONFIG_HWMON and decides that he/she doesn't
> need anything there and deselects HWMON, and disables the ACPI power
> meter driver as a result. Lastly, there is no guarantee that
> CONFIG_HWMON will default to y forever, I admit I'm unsure why it is
> that way.
> 
> I think that it would make more sense to:
> * either move the ACPI power meter driver to drivers/hwmon, and treat
>   it like any other hardware monitoring driver, with a dependency on
>   ACPI;
> * or leave the ACPI power meter driver in drivrs/acpi, but turn the
>   "depends on HWMON" into "select HWMON", so it can't be hidden or
>   unselected by accident.
> 
> Opinion anyone?

I don't have a problem with either; if I had to choose I'd pick the first
option.

--D
> 
> -- 
> Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux