> -----Original Message----- > From: Thomas Renninger [mailto:trenn@xxxxxxx] > Sent: Tuesday, March 01, 2011 1:08 PM > To: Moore, Robert > Cc: Bjorn Helgaas; lenb@xxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] pnpacpi: Better format error message > > On Tuesday 01 March 2011 18:03:23 Moore, Robert wrote: > > - there seem to be another problem in the acpica resource handling > > depths if _CRS functions do not return anything. > > > > > > Strictly speaking it's illegal for _CRS to not return anything. > > Practically, perhaps we should repair this case to a "NULL" resource > > descriptor which perhaps could be defined as a resource descriptor > > with a single End Tag descriptor. > Be aware that this was an early BIOS. > I am fine if there is an error message if this is not allowed. > It's the first time I saw such a message and an empty resource func. > > Thomas The goal of the repair code is of course to simplify the drivers. What we'd like to be able to do is guarantee that if an AE_OK is returned by the evaluation of a predefined ACPI name, the returned object is of the correct type. It seems to me that a "resource descriptor" is a special type of buffer, so we can add support for that in the repair code. In the _CRS case above, we could return a resource descriptor with simply an EndTag -- the driver can of course squawk about this if it desires. On the other hand, we could just punt on the conversion and just return an OBJECT_TYPE error. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
