On Fri, 2010-12-10 at 06:30 +0800, Rafael J. Wysocki wrote:
> On Monday, December 06, 2010, Lin Ming wrote:
> > This feature provides an automatic device notification for wake devices
> > when a wakeup GPE occurs and there is no corresponding GPE method or
> > handler. Rather than ignoring such a GPE, an implicit AML Notify
> > operation is performed on the parent device object.
> > This feature is not part of the ACPI specification and is provided for
> > Windows compatibility only.
> >
> > Signed-off-by: Lin Ming <ming.m.lin@xxxxxxxxx>
>
> This patch does two things at a time, while only one is mentioned in the
> changelog. The second one is that you change the local variable in
> acpi_ev_asynch_execute_gpe_method() back into a pointer:
>
> ...
> >
> > static void ACPI_SYSTEM_XFACE acpi_ev_asynch_execute_gpe_method(void *context)
> > {
> > - struct acpi_gpe_event_info *gpe_event_info = (void *)context;
> > + struct acpi_gpe_event_info *gpe_event_info = context;
> > acpi_status status;
> > - struct acpi_gpe_event_info local_gpe_event_info;
> > + struct acpi_gpe_event_info *local_gpe_event_info;
> > struct acpi_evaluate_info *info;
> >
> > ACPI_FUNCTION_TRACE(ev_asynch_execute_gpe_method);
> >
> > + /* Allocate a local GPE block */
> > +
> > + local_gpe_event_info =
> > + ACPI_ALLOCATE_ZEROED(sizeof(struct acpi_gpe_event_info));
> > + if (!local_gpe_event_info) {
> > + ACPI_EXCEPTION((AE_INFO, AE_NO_MEMORY, "while handling a GPE"));
> > + return_VOID;
> > + }
> > +
> > status = acpi_ut_acquire_mutex(ACPI_MTX_EVENTS);
> > if (ACPI_FAILURE(status)) {
> > return_VOID;
> > @@ -468,7 +479,7 @@ static void ACPI_SYSTEM_XFACE acpi_ev_asynch_execute_gpe_method(void *context)
> > * Take a snapshot of the GPE info for this level - we copy the info to
> > * prevent a race condition with remove_handler/remove_block.
> > */
> > - ACPI_MEMCPY(&local_gpe_event_info, gpe_event_info,
> > + ACPI_MEMCPY(local_gpe_event_info, gpe_event_info,
> > sizeof(struct acpi_gpe_event_info));
> >
>
> etc. and that should go into a separate patch.
>
> I mean, first fix this local variable mess and _then_ introdiuce the new
> feature. Doing both in one step is guaranteed to confuse people.
OK, I'll separate it.
Thanks for review.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
