On Mon, 2010-10-18 at 13:31 +0800, Len Brown wrote: > patch 5 doesn't look quite right, > because it leaves both > > #define ACPI_BITMASK_PCIEXP_WAKE_STATUS 0x4000 /* ACPI 3.0 */ > and > #define ACPI_BITMASK_PCIEXP_WAKE_DISABLE 0x4000 /* ACPI 3.0 */ > > in aclocal.h > > If we're going to re-name what the original patch did, > then we should finsh the job and delete the original name, yes? No, we don't re-name anything. #define ACPI_BITMASK_PCIEXP_WAKE_STATUS 0x4000 /* ACPI 3.0 */ #define ACPI_BITMASK_PCIEXP_WAKE_DISABLE 0x4000 /* ACPI 3.0 */ These are the bit positions for the status and enable registers. Colin's original patch mis-used ACPI_BITMASK_PCIEXP_WAKE_DISABLE which should be ACPI_BITMASK_PCIEXP_WAKE_STATUS, but it didn't cause any problem because they have the same value 0x4000. Bob has corrected it, see comment #1 at http://www.acpica.org/bugzilla/show_bug.cgi?id=880 Lin Ming > > thanks, > Len Brown, Intel Open Source Technology Center > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
