Do we agree that the original message is unclear? I'm not even sure that ACPI requires this method. Perhaps the message should describe what won't happen because of the missing _BQC method. >-----Original Message----- >From: Matthew Garrett [mailto:mjg59@xxxxxxxxxxxxx] >Sent: Tuesday, August 17, 2010 6:35 AM >To: Zhang, Rui >Cc: Brown, Len; linux-acpi@xxxxxxxxxxxxxxx; Moore, Robert; Thomas Renninger >Subject: Re: [PATCH] ACPI video: fix a poor error message > >On Tue, Aug 17, 2010 at 10:42:55AM +0800, Zhang Rui wrote: >> *cap |= ACPI_VIDEO_BACKLIGHT; >> if (ACPI_FAILURE(acpi_get_handle(handle, "_BQC", &h_dummy))) >> - printk(KERN_WARNING FW_BUG PREFIX "ACPI brightness " >> - "control misses _BQC function\n"); >> + printk(KERN_WARNING FW_BUG PREFIX "could not find " >> + "required _BQC function\n"); > >I don't really like the "required". It's a spec requirement but the >driver will work fine (if suboptimally) without it. > >-- >Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
