Re: [PATCH] ACPI video: fix a poor error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 17, 2010 at 10:42:55AM +0800, Zhang Rui wrote:
>  		*cap |= ACPI_VIDEO_BACKLIGHT;
>  		if (ACPI_FAILURE(acpi_get_handle(handle, "_BQC", &h_dummy)))
> -			printk(KERN_WARNING FW_BUG PREFIX "ACPI brightness "
> -					"control misses _BQC function\n");
> +			printk(KERN_WARNING FW_BUG PREFIX "could not find "
> +					"required _BQC function\n");

I don't really like the "required". It's a spec requirement but the 
driver will work fine (if suboptimally) without it.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux