On Fri, 11 Jun 2010, Zhang Rui wrote: > ACPI debugfs I/F should not depend on CONFIG_ACPI_DEBUG. It would be good to state how much size you are adding to ACPI here -- since it will be an additional size burnden to those not already shipping with CONFIG_ACPI_DEBUG=y. > Introduce driver/acpi/debugfs.c for ACPI debugfs I/F. > > No function change in this patch. > > Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx> > --- > drivers/acpi/Makefile | 1 > drivers/acpi/bus.c | 1 > drivers/acpi/debug.c | 75 --------------------------------------------- > drivers/acpi/debugfs.c | 80 ++++++++++++++++++++++++++++++++++++++++++++++++ > drivers/acpi/internal.h | 1 > 5 files changed, 83 insertions(+), 75 deletions(-) > > Index: linux-2.6/drivers/acpi/debugfs.c > =================================================================== > +++ linux-2.6/drivers/acpi/Makefile > @@ -38,6 +38,7 @@ acpi-$(CONFIG_ACPI_DOCK) += dock.o > acpi-y += pci_root.o pci_link.o pci_irq.o pci_bind.o > acpi-y += power.o > acpi-y += system.o event.o > +acpi-y += debugfs.o > acpi-$(CONFIG_ACPI_DEBUG) += debug.o Perhaps it would make sense for this file to depend on CONFIG_DEBUG_FS and have it cost 0-bytes when not set -- along with a static inline for acpi_debugfs_init()? Though honestly, with CONFIG_TRACING and others selecting it, DEBUG_FS is probably enabled on most systems... thanks, -Len Brown, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
