On Wednesday, May 19, 2010 09:43:09 am Matthew Garrett wrote: > Various machines (https://bugzilla.redhat.com/show_bug.cgi?id=585756 for > instance) contain SystemIO spaces with addresses > 16 bits. acpica throws > an error for this, while Windows silently ignores the upper 16 bits and > carries on happily. Provide support for the latter behaviour for bug > compatibility. > > + if (acpi_gbl_ignore_high_ioport_bits) > + /* Windows only uses the lower 16 bits of an address. > + Emulate that */ > + address &= 0xffff; I think this is a good idea. But it makes me a little bit nervous to change addresses supplied by the firmware without any user-visible indication at all. Is it worth doing a WARN_ONCE() sort of thing when we truncate? I know you experimented quite a bit to confirm that Windows does this sort of masking. Do you have any notes about that experimentation that would be useful to add to the bugzilla? Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
