On Mon, 2010-04-26 at 07:38 -0300, Henrique de Moraes Holschuh wrote: > On Sun, 25 Apr 2010, Jerone Young wrote: > > No ACPI event is sent by the mute key. This is on my X301 & T61 (already > > in blacklist.c). They must be doing some polling, as I remember there > > being a slight delay when you press the mute key and Windows getting the > > update from the userspace daemon. > > Please test on the T400 and T410, if possible. The T410 sends a soft keypress & hardware keypress at the same time (it also turns on the LED on the mute key .. which indicates the hardware mute is on for the speakers). No acpi event. With the X201 & W510 (2nd hand data on the W510) they ONLY send a mute soft keypress .. no more hardware mute. So no way to fall out of sync. They also don't have a LED on the mute key. No acpi event. Unfortunately don't have or know anyone around with a T400 to get more data from it. But looks like any machine Lenovo produced during this time had the exact same thing going on. > > > Comparing GPEs across several IBM-heritage DSDTs (ignore the X100e and > > > other OEM crap with a thinkpad name), I think it comes in as 'hotkeys' > > > (i.e. 0x10xx HKEY events). Please enable the high eight bits on the > > > thinkpad-acpi hotkey mask, assign keycodes to those keys, and tell me > > > what you find. Make sure to have OSI(Linux) *disabled*, I very much > > > doubt it works in "Linux" mode. > > > > Since it sends no acpi event there is no way for it to catch it. Could > > I be wrong? > > There are three new HKEY events on some of the newer thinkpads (I don't know > if they exist in the X300/X301). They're hooked to suspicious GPEs that are > the same as the ones for volume feedback on all other thinkpads. > Hmmm .. not my X301, I have the latest bios/ec update also. > Whatever solution I will adopt, won't be one for the X300 in particular. It > needs to be one that won't be a hindrance in the next two years at least. > > I need more data on the newest models first, to make an informed decision. > It is entirely possible that the X300/T61 generation require a different > solution than the earlier models. And it is entirely possible that the T410 > and newer allow for a better solution than the X300/T61. Looks like on the newest Models. Lenovo is beginning to move away from hardware mute. > > EC polling is bad, hardware state unsynced is worse. And any polling done > in userspace is Ugly, Bad, and will bite us back when it is not needed > anymore. > > thinkpad-acpi is perfectly capable of doing polling on its own so that it > becomes transparent to userspace, and userspace won't screw over the owners > of thinkpads that don't need polling. > > So, it is not that I am against the OSI(Linux) patch. But I *do* want the > full data... Sure that sounds reasonable. > > > The problem here as I describe in my last email is that thinkpad-acpi > > cannot full fix this issue. You need to have a userspace daemon to > > interact with the userspace sound server. > > But you can send full state messages using EV_SW or some other channel, to > force userspace into sync with the hardware state (if we can get to the > hardware state). I'd rather find out whether we need that on the newest > generation of thinkpads *before* userspace starts expecting a certain > behaviour from the thinkpad. It looks like not .. see first paragraph. > > > What is getting me guys is that we have machines already doing this > > right now in the code from the same time period (They where put there to > > solve the exact same issue). This is just an extension of those > > machines. I think what we are discussing now is a separate possible > > solution. But for the short term we should black list these machines > > also, till can sort it out. Once it is we can unblack list all of them. > > I don't mind short-term solutions. But I *do* mind any future pressure to > keep them around instead of fixing things properly even if we will need to > break userspace hacks. I am not yet sure this won't be the case, here. I could agree. Though after seeing the behavior of the new Thinkpads I realized Lenovo was just making the bahavior exactly what they had OSI(Linux) on the old Thinkpads. > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
