Re: [PATCH] Fix mute key on older Thinkpads by OSI blacklisting them

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 24 Apr 2010, Jerone Young wrote:
> On Sat, 2010-04-24 at 22:16 +0100, Matthew Garrett wrote:
> > On Sat, Apr 24, 2010 at 03:49:38PM -0500, Jerone Young wrote:
> > 
> > > The issue is the way Windows does it is through a userspace daemon.  By
> > > making it OSI=Linux (just as with the Thinkpads currently already in
> > > blacklist.c ..*61 line) the machines just send the OS a key press.
> > 
> > And how does that userspace daemon receive the event?
> 
> Well it's a daemon and a suite. Don't know if you have ever seen a
> Thinkpad with Windows? .. but has a lot of Think tools & such. Apart of
> these tools is an OSD as well.

Matthew is quite used to ThinkPads, and so am I.  Believe me, it should
be an ACPI event, either HKEY or GPE.  They don't do direct EC access in
Windows if they can help it, least of all polled access...

Comparing GPEs across several IBM-heritage DSDTs (ignore the X100e and
other OEM crap with a thinkpad name), I think it comes in as 'hotkeys'
(i.e. 0x10xx HKEY events).  Please enable the high eight bits on the
thinkpad-acpi hotkey mask, assign keycodes to those keys, and tell me
what you find.  Make sure to have OSI(Linux) *disabled*, I very much
doubt it works in "Linux" mode.

> event happens and changes things at that Level (maybe by sending a mute
> key press??) .. but at the Windows userspace Level things get muted and

Most likely it will mute the mixer directly.  And so should we, trying
to sync states over the input layer using EV_KEY is UTTERLY BROKEN, and
fully into Don't Ever Do That territory.

I will provide proper support through thinkpad-acpi (which is *NOT* a
EV_KEY. EV_SW, a thinkpad-specific event, a poll()'able sysfs
attribute...), if there is a need.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux