On Tuesday 05 January 2010 18:04:39 H. Peter Anvin wrote:
> On 01/05/2010 04:30 AM, Christian Hofstaedtler wrote:
> > Newer hardware is assumed to no longer reboot succesfully using the
> > keyboard controller, but needs to use ACPI instead.
> > To not cause problems with older hardware, only hardware with a BIOS
> > date 2006 or newer is considered for this choice.
> >
> > Also unifiy reboot_type selection code.
> >
> > + }
> > + /* 0? Likely a buggy new BIOS */
> > + if (year == 0) {
> > + printk(KERN_ERR "reboot: DMI BIOS year==0, "
> > + "assuming ACPI-reboot-capable machine\n");
> > + return 1;
> > + }
> > + /* 2006 was decided as the cut-off year. */
> > + if (year < 2006) {
> > + return 0;
> > + }
> > + return 1;
> > +}
> > +
>
> Why assume it is a buggy *new* BIOS rather than a buggy *old* BIOS?
Well, this is the same as with CONFIG_ACPI_BLACKLIST_YEAR. But yeah, I've also
thought about it, but then *I* really don't know how many such broken BIOSes
are there in the wild. And how many of them are new enough.
Also, I think we could push the year even more up, say, to 2009. On the
assumption that such new hardware which can't do BOOT_KBD is only being
produced now (late 2009). Better err on the safe side?
Christian
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
