On Thu, 24 Dec 2009, Dmitry Torokhov wrote:
> + for (i = 0; i < ARRAY_SIZE(sony_laptop_input_keycode_map); i++)
> + __set_bit(sony_laptop_input_keycode_map[i], key_dev->keybit);
> + __clear_bit(KEY_RESERVED, key_dev->keybit);
Maybe:
for (i = 0; i < ARRAY_SIZE(sony_laptop_input_keycode_map); i++) {
if (sony_laptop_input_keycode_map[i] != KEY_RESERVED) {
input_set_capability(key_dev, EV_KEY,
sony_laptop_input_keycode_map[i]);
}
}
would be better, as it means the driver doesn't poke into the inputdev
struct innards directly?
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
