On Fri, 4 Dec 2009 10:10:09 +0100 Anisse Astier wrote: > > These function allocate an acpi object by calling wmi_get_event_data, which > then calls acpi_evaluate_object, and it is not freed afterwards. > > And kernel doc is fixed for parameters of wmi_get_event_data. > > Signed-off-by: Anisse Astier <anisse@xxxxxxxxx> Ack and thanks for doing that. > --- > There it is, > > Fixed the kernel doc in this patch. > > Anisse > > drivers/platform/x86/dell-wmi.c | 1 + > drivers/platform/x86/hp-wmi.c | 2 ++ > drivers/platform/x86/wmi.c | 4 ++-- > 3 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > index 0f900cc..f235a98 100644 > --- a/drivers/platform/x86/dell-wmi.c > +++ b/drivers/platform/x86/dell-wmi.c > @@ -180,6 +180,7 @@ static void dell_wmi_notify(u32 value, void *context) > printk(KERN_INFO "dell-wmi: Unknown key %x pressed\n", > buffer[1] & 0xFFFF); > } > + kfree(obj); > } > > static int __init dell_wmi_input_setup(void) > diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c > index c284217..36109e1 100644 > --- a/drivers/platform/x86/hp-wmi.c > +++ b/drivers/platform/x86/hp-wmi.c > @@ -377,6 +377,8 @@ static void hp_wmi_notify(u32 value, void *context) > eventcode); > } else > printk(KERN_INFO "HP WMI: Unknown response received\n"); > + > + kfree(obj); > } > > static int __init hp_wmi_input_setup(void) > diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c > index 177f8d7..87f4c97 100644 > --- a/drivers/platform/x86/wmi.c > +++ b/drivers/platform/x86/wmi.c > @@ -510,8 +510,8 @@ EXPORT_SYMBOL_GPL(wmi_remove_notify_handler); > /** > * wmi_get_event_data - Get WMI data associated with an event > * > - * @event - Event to find > - * &out - Buffer to hold event data > + * @event: Event to find > + * @out: Buffer to hold event data. out->pointer should be freed with kfree() > * > * Returns extra data associated with an event in WMI. > */ > -- > 1.6.5.3 > --- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
