Re: [PATCH] wmi: Free the allocated acpi objects through wmi_get_event_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 3 Dec 2009 17:27:45 +0100 Anisse Astier wrote:

> 
> These function allocate an acpi object by calling wmi_get_event_data, which
> then calls acpi_evaluate_object, and it is not freed afterwards
> 
> Signed-off-by: Anisse Astier <anisse@xxxxxxxxx>
> ---
>  drivers/platform/x86/dell-wmi.c |    1 +
>  drivers/platform/x86/hp-wmi.c   |    2 ++
>  drivers/platform/x86/wmi.c      |    2 +-
>  3 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 5f4a0e6..cd48a2f 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -121,6 +121,7 @@ static void dell_wmi_notify(u32 value, void *context)
>  			printk(KERN_INFO "dell-wmi: Unknown key %x pressed\n",
>  			       buffer[1] & 0xFFFF);
>  	}
> +	kfree(obj);
>  }
>  
>  static int __init dell_wmi_input_setup(void)
> diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
> index 8868610..8eba327 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -316,6 +316,8 @@ static void hp_wmi_notify(u32 value, void *context)
>  			       eventcode);
>  	} else
>  		printk(KERN_INFO "HP WMI: Unknown response received\n");
> +
> +	kfree(obj);
>  }
>  
>  static int __init hp_wmi_input_setup(void)
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index 177f8d7..b486048 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -511,7 +511,7 @@ EXPORT_SYMBOL_GPL(wmi_remove_notify_handler);
>   * wmi_get_event_data - Get WMI data associated with an event
>   *
>   * @event - Event to find
> - * &out - Buffer to hold event data
> + * &out - Buffer to hold event data. out.pointer should be freed with kfree()
>   *
>   * Returns extra data associated with an event in WMI.
>   */
> -- 

Hi,

All of the kernel-doc in wmi.c is in the correct format except for this (above)
function.  Please fix it to use the expected kernel-doc notation:

 * @event: Event to find
 * @out: Buffer to hold event data. out.pointer should be freed with kfree()


thanks,
---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux