Re: [patch 04/12] cmpc_acpi: add support for Classmate PC ACPI devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/18/09, Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxxx> wrote:
> Since Andrew has put some patches over the first version, I had some
> doubts on how to handle the fixes. Should I import those patches as git
> patches and submit them together with many other patches fixing every
> issue in its own commit? Or should I write another version and write a
> log in the commit message?
>
> UPDATE:
> I've just fixed every issue reported. How should I send it?
>
> Regards,
> Cascardo.

Great!  I would send the revised version as a new patch.  Normally the
log of changes is not included in the commit message, because they
don't make much sense out of context.  I.e.

    commit message
    ---
      log of changes to original version here; git will ignore it

    diff ...

Thanks
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux